lkml.org 
[lkml]   [2006]   [Nov]   [23]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 23 Nov 2006 12:39:05 -0700
FromMatthew Wilcox <>
SubjectRe: [PATCH 3/5] PCI : Add selected_regions funcs
On Thu, Nov 23, 2006 at 08:33:32PM +0100, Ingo Oeser wrote:
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".

Why?  We know how many BARs PCI devices have (6.  Plus ROM.  Plus 4
bridge resources, making 11).  We could even use a u16.  An int is fine,
there's no need to re-spin this patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-23 19:41    [W:0.070 / U:0.030 seconds]
©2003-2008 Jasper Spaans