Messages in this thread | | | Date | Wed, 22 Nov 2006 07:42:20 +0100 | From | Pierre Ossman <> | Subject | Re: [PATCH 1/1] MMC: new version of the TI Flash Media card reader driver |
| |
Alex Dubov wrote: > I know that the patch is too big, but I have no way to split it up. Basically, I've changed so > many things (I had quite a few problems with interrupts after suspend/resume) that it can be > regarded as a brand new driver. My SVN became somewhat messy too. > > I can post the driver in it full (non-diff) form or as a 4 per-file diffs, but I have no way to > split it up into per-issue form (except for issues 3 and 5, which are one-liners). >
That's a start. But 4 sounds like it could be broken out with some work.
I'm not saying it's trivial to break this apart, but it is something that needs to be done. At the very least the commit messages need to reflect what is changed and why.
See it as practice as this is an issue you will be hit by now and then as a kernel developer. :)
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |