Messages in this thread Patch in this message | | | Date | Thu, 23 Nov 2006 03:41:11 +0900 | From | Akinobu Mita <> | Subject | [PATCH] tlclk: fix platform_device_register_simple() error check |
| |
The return value of platform_device_register_simple() should be checked by IS_ERR().
This patch also fix misc_register() error case. Because misc_register() returns error code.
Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
--- drivers/char/tlclk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Index: work-fault-inject/drivers/char/tlclk.c =================================================================== --- work-fault-inject.orig/drivers/char/tlclk.c +++ work-fault-inject/drivers/char/tlclk.c @@ -792,15 +792,14 @@ static int __init tlclk_init(void) ret = misc_register(&tlclk_miscdev); if (ret < 0) { printk(KERN_ERR "tlclk: misc_register returns %d.\n", ret); - ret = -EBUSY; goto out3; } tlclk_device = platform_device_register_simple("telco_clock", -1, NULL, 0); - if (!tlclk_device) { + if (IS_ERR(tlclk_device)) { printk(KERN_ERR "tlclk: platform_device_register failed.\n"); - ret = -EBUSY; + ret = PTR_ERR(tlclk_device); goto out4; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |