Messages in this thread | | | Date | Wed, 22 Nov 2006 09:13:24 -0800 | From | Venkatesh Pallipadi <> | Subject | Re: [RFC][PATCH] Add do_not_call_when_idle option to timer and workqueue |
| |
On Tue, Nov 21, 2006 at 06:11:14PM -0800, Andrew Morton wrote: > On Tue, 21 Nov 2006 16:28:45 -0800 > Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> wrote: > > > > > struct timer_list { > > struct list_head entry; > > unsigned long expires; > > @@ -16,6 +18,7 @@ > > unsigned long data; > > > > struct tvec_t_base_s *base; > > + int flags; > > #ifdef CONFIG_TIMER_STATS > > Adding a new field to the timer_list is somewhat of a hit - this is going > to make an awful lot of data structures a bit larger. Some of which we > allocate a large number of. > > I think we could justfy getting nasty and using the LSB of > timer_list.function for this..
That is a clever idea... Is that going to work in all architectures with all compiler flags?
> > #define DEFINE_TIMER(_name, _function, _expires, _data) \ > > Index: linux-2.6.19-rc-mm/include/linux/workqueue.h > > =================================================================== > > --- linux-2.6.19-rc-mm.orig/include/linux/workqueue.h 2006-11-13 15:06:26.000000000 -0800 > > +++ linux-2.6.19-rc-mm/include/linux/workqueue.h 2006-11-13 16:01:03.000000000 -0800 > > @@ -65,6 +65,8 @@ > > extern int FASTCALL(queue_delayed_work(struct workqueue_struct *wq, struct work_struct *work, unsigned long delay)); > > extern int queue_delayed_work_on(int cpu, struct workqueue_struct *wq, > > struct work_struct *work, unsigned long delay); > > +extern int queue_soft_delayed_work_on(int cpu, struct workqueue_struct *wq, > > + struct work_struct *work, unsigned long delay); > > I don't think that's a well-chosen name. What does the "soft" mean? > > Also, this is a new timer API capability, but it is only exposed via the > workqueue API, and then only via a part of it. > > A complete implementation would expose the new capability via extensions to > the timer API, and would then (in a separate patch) convert the workqueue > API to use those extensions. (And in fact the third patch would convert > cpufreq to use the new workqueue capabilities...) >
I agree with all API related comments. I will clean it up in the next refresh of the patch. I wanted to get the comments on this mechanism in general and wanted to be doubly sure that I am not breaking anything in cascading timer by doing something like this. Looks like the mechanism is OK. So, I will work on a cleaner patch and repost.
Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |