![]() | |||||||||||||
Messages in this thread |
On Tue, 2006-11-21 at 11:48 +0300, Pavel Emelianov wrote: > Vivek noted that many places call note_interrupt() > without desc->lock being held. Since note_interrupt() > which tries to unlock this lock to handle spurious > interrupts accodring to > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f72fa707604c015a6625e80f269506032d5430dc > > Looking at note_interrupt() I found that desc->lock > IS required in this function but all the places that > call note_interrupt() lock it after the call. One > exception from this rule is __do_IRQ(). > > So I move spin_lock(&desc->lock); before calling > note_interrupt() in all places. > > Signed-off-bt: Pavel Emelianov <xemul@openvz.org> indeed - and this is a fallout of the earlier fix in note_interrupt(). Andrew, Linus: i think this is a must-have for 2.6.19 as well. Acked-by: Ingo Molnar <mingo@redhat.com> Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-11-21 20:31 [from the cache] ©2003-2008 | |||||||||||||