Messages in this thread | | | Date | Thu, 2 Nov 2006 05:43:05 -0500 | From | Jakub Jelinek <> | Subject | Re: [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h |
| |
On Thu, Nov 02, 2006 at 07:19:42PM +0900, Magnus Damm wrote: > --- 0001/include/linux/elf.h > +++ work/include/linux/elf.h 2006-11-02 15:44:10.000000000 +0900 > @@ -352,12 +352,16 @@ typedef struct elf64_note { > Elf64_Word n_type; /* Content type */ > } Elf64_Nhdr; > > +typedef Elf64_Off elf64_addr; > +typedef Elf32_Off elf32_addr; > +
What are these typedefs useful for? Isn't it better just to use Elf32_Addr and Elf64_Addr in the #defines below?
> #if ELF_CLASS == ELFCLASS32 > > extern Elf32_Dyn _DYNAMIC []; > #define elfhdr elf32_hdr > #define elf_phdr elf32_phdr > #define elf_note elf32_note > +#define elf_addr_t elf32_addr > > #else > > @@ -365,6 +369,7 @@ extern Elf64_Dyn _DYNAMIC []; > #define elfhdr elf64_hdr > #define elf_phdr elf64_phdr > #define elf_note elf64_note > +#define elf_addr_t elf64_addr > > #endif
Jakub - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |