Messages in this thread | | | Date | Mon, 20 Nov 2006 00:49:03 +0100 | From | Alessandro Zummo <> | Subject | Re: [patch 2.6.19-rc6] rtc class locking bugfixes |
| |
On Thu, 16 Nov 2006 23:27:37 -0800 David Brownell <david-b@pacbell.net> wrote:
> I got a lockdep warning when running "rtctest" so I though it'd be good > to see what was up. > > - The warning was for rtc->irq_task_lock, gotten from rtc_update_irq() > by irq handlerss ... but in a handful of other cases, grabbed without > blocking IRQs. > > - Some callers to rtc_update_irq() were not ensuring IRQs were blocked, > yet the routine expects that; make sure all callers block IRQs. > > It would appear that RTC API tests haven't been part of anyone's kernel > regression test suite recently, at least not with lockdep running. > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo, Tower Technologies - Turin, Italy
http://www.towertech.it
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |