lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/15] aic94xx: Delete ascb timers when freeing queues
    Date

    When the aic94xx driver creates ascbs, each ascb is initialized with a
    timeout timer. If there are any ascbs left over when the driver is being
    torn down, these timers need to be deleted. In particular, we seem to
    hit this case when ascbs are issued yet never end up on the done list.
    Right now there's a sequencer bug that results in this happening every
    so often. CONTROL PHY commands also use these per-ascb timers.

    We also want to print a warning if there are leftover ascbs that are
    not for CONTROL PHY commands.

    Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
    ---

    drivers/scsi/aic94xx/aic94xx_init.c | 9 +++++++++
    1 files changed, 9 insertions(+), 0 deletions(-)

    diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
    index f7f009e..d9cf607 100644
    --- a/drivers/scsi/aic94xx/aic94xx_init.c
    +++ b/drivers/scsi/aic94xx/aic94xx_init.c
    @@ -727,6 +727,15 @@ static void asd_free_queues(struct asd_h

    list_for_each_safe(pos, n, &pending) {
    struct asd_ascb *ascb = list_entry(pos, struct asd_ascb, list);
    + /*
    + * Delete unexpired ascb timers. This may happen if we issue
    + * a CONTROL PHY scb to an adapter and rmmod before the scb
    + * times out. Apparently we don't wait for the CONTROL PHY
    + * to complete, so it doesn't matter if we kill the timer.
    + */
    + del_timer_sync(&ascb->timer);
    + WARN_ON(ascb->scb->header.opcode != CONTROL_PHY);
    +
    list_del_init(pos);
    ASD_DPRINTK("freeing from pending\n");
    asd_ascb_free(ascb);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-17 22:11    [W:2.671 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site