lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [patch, -rc6] x86_64: UP build fixes
    Date
    On Thursday 16 November 2006 09:48, Ingo Molnar wrote:

    > arch/x86_64/kernel/vsyscall.c: In function 'cpu_vsyscall_notifier':
    > arch/x86_64/kernel/vsyscall.c:282: warning: implicit declaration of function 'smp_call_function_single'
    > arch/x86_64/kernel/vsyscall.c: At top level:
    > arch/x86_64/kernel/vsyscall.c:279: warning: 'cpu_vsyscall_notifier' defined but not used


    Oops. My fault indeed.

    Here's a simpler patch to fix it.

    -Andi

    Fix vsyscall.c compilation on UP

    Broken by earlier patch by me.

    Index: linux/arch/x86_64/kernel/vsyscall.c
    ===================================================================
    --- linux.orig/arch/x86_64/kernel/vsyscall.c
    +++ linux/arch/x86_64/kernel/vsyscall.c
    @@ -274,6 +274,7 @@ static void __cpuinit cpu_vsyscall_init(
    vsyscall_set_cpu(raw_smp_processor_id());
    }

    +#ifdef CONFIG_HOTPLUG_CPU
    static int __cpuinit
    cpu_vsyscall_notifier(struct notifier_block *n, unsigned long action, void *arg)
    {
    @@ -282,6 +283,7 @@ cpu_vsyscall_notifier(struct notifier_bl
    smp_call_function_single(cpu, cpu_vsyscall_init, NULL, 0, 1);
    return NOTIFY_DONE;
    }
    +#endif

    static void __init map_vsyscall(void)
    {
    @@ -303,7 +305,9 @@ static int __init vsyscall_init(void)
    register_sysctl_table(kernel_root_table2, 0);
    #endif
    on_each_cpu(cpu_vsyscall_init, NULL, 0, 1);
    +#ifdef CONFIG_HOTPLUG_CPU
    hotcpu_notifier(cpu_vsyscall_notifier, 0);
    +#endif
    return 0;
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-16 10:05    [W:4.691 / U:1.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site