lkml.org 
[lkml]   [2006]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 14/30] NET: __alloc_pages() failures reported due to fragmentation
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------
    From: David Miller <davem@davemloft.net>

    We have seen a couple of __alloc_pages() failures due to
    fragmentation, there is plenty of free memory but no large order pages
    available. I think the problem is in sock_alloc_send_pskb(), the
    gfp_mask includes __GFP_REPEAT but its never used/passed to the page
    allocator. Shouldnt the gfp_mask be passed to alloc_skb() ?

    Signed-off-by: Larry Woodman <lwoodman@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    ---
    net/core/sock.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    --- linux-2.6.18.2.orig/net/core/sock.c
    +++ linux-2.6.18.2/net/core/sock.c
    @@ -1164,7 +1164,7 @@ static struct sk_buff *sock_alloc_send_p
    goto failure;

    if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) {
    - skb = alloc_skb(header_len, sk->sk_allocation);
    + skb = alloc_skb(header_len, gfp_mask);
    if (skb) {
    int npages;
    int i;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-16 03:57    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean