Messages in this thread Patch in this message | | | Date | Wed, 15 Nov 2006 18:44:02 -0800 | From | Chris Wright <> | Subject | [patch 30/30] CIFS: New POSIX locking code not setting rc properly to zero on successful |
| |
-stable review patch. If anyone has any objections, please let us know. ------------------
From: Steve French <sfrench@us.ibm.com>
unlock in case where server does not support POSIX locks and nobrl is not specified.
Signed-off-by: Steve French <sfrench@us.ibm.com> Signed-off-by: Chris Wright <chrisw@sous-sol.org> --- fs/cifs/file.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index e9c5ba9..ddb012a 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -752,6 +752,7 @@ int cifs_lock(struct file *file, int cmd int stored_rc = 0; struct cifsLockInfo *li, *tmp; + rc = 0; down(&fid->lock_sem); list_for_each_entry_safe(li, tmp, &fid->llist, llist) { if (pfLock->fl_start <= li->offset && @@ -766,7 +767,7 @@ int cifs_lock(struct file *file, int cmd kfree(li); } } - up(&fid->lock_sem); + up(&fid->lock_sem); } } -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |