Messages in this thread | | | Date | Wed, 15 Nov 2006 19:36:10 +0100 | From | Mattia Dongili <> | Subject | Re: 2.6.19-rc5-mm2 |
| |
On Wed, Nov 15, 2006 at 10:06:23AM -0800, Pallipadi, Venkatesh wrote: [...] > >Venki, I'm a little worried about the switch/case in question (line > >702): the data->cpu_feature is set either to SYSTEM_IO_CAPABLE or > >SYSTEM_INTEL_MSR_CAPABLE just a few lines above so it seems the switch > >variable is wrong and none of the 2 cases will ever get a chance to > >execute. > > > > The variable is set few lines before. So, it should be OK to switch on > that > variable set and one of the two cases will execute. isn't it? Or am > I missing something?
Yes, patch is coming.
> >Unfortunately I don't have enough knowledge to tell if it's simply > >necessary to fix the switch variable as > > Get_cur_freq_on_cpu will not work on SYSTEM_IO space as ACPI does not > have an interface to get the current frequency. It only has a interface > to say whether the last transitions tried was successful or not. > So, if indeed a change in switch is required, first option should be > good...
Hmmmm... I see, the following path fooled me, but re-reading it seems more obvious what it is doing :)
get_cur_freq_on_cpu extract_freq switch (data->cpu_feature) { case SYSTEM_INTEL_MSR_CAPABLE: return extract_msr(val, data); case SYSTEM_IO_CAPABLE: return extract_io(val, data); ...
-- mattia :wq! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |