Messages in this thread | | | Subject | RE: 2.6.19-rc5-mm2 | Date | Wed, 15 Nov 2006 10:06:23 -0800 | From | "Pallipadi, Venkatesh" <> |
| |
>-----Original Message----- >From: Mattia Dongili [mailto:malattia@linux.it] >Sent: Wednesday, November 15, 2006 9:47 AM >To: Pallipadi, Venkatesh >Cc: ego@in.ibm.com; Reuben Farrelly; Andrew Morton; >davej@redhat.com; linux-kernel@vger.kernel.org; CPUFreq >Mailing List; Sadykov, Denis M >Subject: Re: 2.6.19-rc5-mm2 > >On Wed, Nov 15, 2006 at 06:09:47AM -0800, Pallipadi, Venkatesh wrote: >[...] >> >data->cpu_feature == ACPI_ADR_SPACE_FIXED_HARDWARE. >> >> Yes. Patch from Mattia is indeed required for acpi-cpufreq. >> Mattia: Can you please send the patch towards Andrew (With signed off >> etc) for inclusion. > >Venki, I'm a little worried about the switch/case in question (line >702): the data->cpu_feature is set either to SYSTEM_IO_CAPABLE or >SYSTEM_INTEL_MSR_CAPABLE just a few lines above so it seems the switch >variable is wrong and none of the 2 cases will ever get a chance to >execute. >
The variable is set few lines before. So, it should be OK to switch on that variable set and one of the two cases will execute. isn't it? Or am I missing something?
>Unfortunately I don't have enough knowledge to tell if it's simply >necessary to fix the switch variable as
Get_cur_freq_on_cpu will not work on SYSTEM_IO space as ACPI does not have an interface to get the current frequency. It only has a interface to say whether the last transitions tried was successful or not. So, if indeed a change in switch is required, first option should be good...
Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |