Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 19/19] CacheFiles: Permit daemon to probe inuseness of a cache file | Date | Wed, 15 Nov 2006 16:10:08 +0000 |
| |
Christoph Hellwig <hch@infradead.org> wrote:
> Once again a very strong NACK for anything that gets a fd argument as > text from userspace.
Why? Would you rather I passed it in a struct to an ioctl?
> Also a very strong NACK for use of fget/fget_light from non-core code and > exports for either of them.
Why?
I could possibly pass the pathname as text, except that (a) the path length may exceed PAGE_SIZE and MAXPATHLEN, and (b) doing a full path lookup() is a complete waste of time as the daemon already has the directory open on a file descriptor, and so effectively has a bookmark to the location that I can use, if I can but get hold of it.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |