Messages in this thread | | | Date | Tue, 14 Nov 2006 10:48:44 +0000 | From | Russell King <> | Subject | Re: How to cleanly shut down a block device |
| |
On Tue, Nov 14, 2006 at 09:54:58AM +0100, Pierre Ossman wrote: > I've had another look at it, and I believe I have a solution. There is > one assumption I need to verify though. > > After del_gendisk() and after I've flushed out any remaining requests, > is it ok to kill off the queue? Someone might still have the disk open, > so that would mean the queue is gone by the time gendisk's release > function is called.
Just arrange for the mmc_queue_thread() to empty the queue when MMC_QUEUE_EXIT is set, and then exit. I thought this was something that the block layer looked after (Jens must have missed this in his original review of the MMC code.)
The handling of userspace keeping the device open despite the hardware having been removed is already in place.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |