lkml.org 
[lkml]   [2006]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC] [PATCH 10/16] x86_64: 64bit PIC ACPI wakeup
Date
On Wednesday 15 November 2006 00:43, Pavel Machek wrote:
> Hi!
>
> > >> I don't have a configuration I can test this but it compiles cleanly
> > >
> > > Ugh, now that's a big patch.. and untested, too :-(.
> >
> > It was very carefully code reviewed at least the first time,
> > and the code was put in sync with code that was tested.
>
> So we had two very different versions of "switch to 64-bit" and now we
> have two mostly similar versions. Not a big improvement...

Hmm? That's an improvement in my book. Of course i would prefer
truly shared code, but even more similar code is better.

> > > Why is PGE no longer required, for example?
> >
> > PGE is never required. Especially on a temporary page table.
> > PGE is an optimization, to make context switches faster.
>
> HPA tells me it is.

He was just nitpicking. Eric is right it is just an optimization
(modulo hardware/software bugs)

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-15 04:53    [W:0.197 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site