Messages in this thread Patch in this message | | | Date | Tue, 14 Nov 2006 11:32:50 -0500 | From | Mark Lord <> | Subject | Re: [git patches] libata fixes |
| |
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 7af2a4b..5c1fc46 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1612,9 +1612,9 @@ early_finish: err_did: ata_qc_free(qc); -err_mem: cmd->result = (DID_ERROR << 16); done(cmd); +err_mem: DPRINTK("EXIT - internal\n"); return 0;
This doesn't look correct to me, but I did miss out on the original discussion(?). Any time we return 0 from queuecommand, the SCSI mid-layer expects us to also take care of invoking the done() function. Where does this now happen for this case (err_mem) ???
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |