Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h | Date | Tue, 14 Nov 2006 02:46:28 +0100 |
| |
> > I think we need these UL suffixes. Otherwise in some cases overflow > can take place and compiler emits warning. > > For ex. in following definition I got rid of UL. > > #define PGDIR_SIZE (1 << PGDIR_SHIFT)
Yes for the shifts it is needed, but not for the unshifted constants. I think. At least when they're hex the compiler should chose the right type on its own.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |