Messages in this thread |  | | | Date | Mon, 13 Nov 2006 09:12:22 +0000 | | From | Russell King <> | | Subject | Re: [patch] fix up generic csum_ipv6_magic function prototype |
| |
On Mon, Nov 13, 2006 at 08:52:23AM +0000, Al Viro wrote: > After doing the above we have the following: > Platform-dependent: > __wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum); > On arm/arm26: T1 = unsigned short, T2 = unsigned int. > __sum16 csum_tcpudp_magic(__be32, __be32, unsigned short, T, __wsum); > On arm/arm26 T is unsigned int, elsewhere it's unsigned short.
Could both become unsigned short or unsigned int. Would prefer unsigned int on ARM, since otherwise the compiler generate code to truncate any variable "int"s to an unsigned short.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |