Messages in this thread Patch in this message | | | Date | Mon, 13 Nov 2006 21:35:23 +0100 | From | Jens Axboe <> | Subject | Re: 2.6.19-rc1 (+ide-cd patches) regression: unable to rip cd |
| |
On Mon, Nov 13 2006, Alex Romosan wrote: > Jens Axboe <jens.axboe@oracle.com> writes: > > > Great, problem fixed then, patch is already merged upstream so > > 2.6.19 and next -rc (if any :-) should work. Thanks for your > > persistent testing. > > i've played with this a little bit more over the weekend. sometimes > cdparanoia gets stuck trying to read some sector. with your patches i > can now stop the process and restart it, and without touching the cd > at all this next time cdparanoia finishes just fine. usually this > happens after i try to rip a series of tracks so i wonder if some > error counters don't get reset or something like that. maybe this is > the expected behaviour, but i don't think i saw cdparanoia get stuck > on the first track ever, usually it happens after some time.
There is a second error handling patch merged with the first patch as well, perhaps it'll help you out. Attached here as well.
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index bddfebd..8821494 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -724,7 +724,7 @@ static int cdrom_decode_status(ide_drive * if we have an error, pass back CHECK_CONDITION as the * scsi status byte */ - if (!rq->errors) + if (blk_pc_request(rq) && !rq->errors) rq->errors = SAM_STAT_CHECK_CONDITION; /* Check for tray open. */ -- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |