lkml.org 
[lkml]   [2006]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] autofs4 - panic after mount fail
FromIan Kent <>
DateMon, 13 Nov 2006 23:55:04 +0800
On Mon, 2006-11-13 at 23:51 +0800, Ian Kent wrote:
> On Mon, 2006-11-13 at 11:07 +0000, David Howells wrote:
> > Ian Kent <raven@themaw.net> wrote:
> >
> > > - if (sbi->pipe) {
> > > - fput(sbi->pipe); /* Close the pipe */
> > > - sbi->pipe = NULL;
> > > - }
> > > + fput(sbi->pipe); /* Close the pipe */
> > > + sbi->pipe = NULL;
> >
> > Ummm... Is that right? fput() doesn't check its argument for a NULL pointer,
> > so the original code shouldn't hurt and should give you an extra bit of
> > defense.
>
> HaHa .. sometimes it's people saying "get id of that you don't need it"
> and other times it's the opposite.
>
> Setting sbi->catatonic = 1 upon entry to autofs[4]_fill_super ensures
> that autofs[4]_catatonic_mode is not called until after sbi->pipe is non
> NULL. So I decided, in this case, to remove the test.

However, if you feel strongly about it I'll change it.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-13 16:59    [from the cache]
©2003-2010