Messages in this thread Patch in this message | | | Date | Sun, 12 Nov 2006 18:48:26 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value |
| |
The Coverity checker noted that bad things might happen if find_isa_irq_apic() returned -1.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/arch/i386/kernel/io_apic.c.old 2006-11-12 18:41:24.000000000 +0100 +++ linux-2.6/arch/i386/kernel/io_apic.c 2006-11-12 18:42:00.000000000 +0100 @@ -2160,7 +2160,8 @@ static inline void unlock_ExtINT_logic(v pin = find_isa_irq_pin(8, mp_INT); apic = find_isa_irq_apic(8, mp_INT); - if (pin == -1) + + if ((pin == -1) || (apic == -1)) return; entry0 = ioapic_read_entry(apic, pin); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |