lkml.org 
[lkml]   [2006]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference
Date

>
> void dev_kfree_skb_any(struct sk_buff *skb)
> {
> if (in_irq() || irqs_disabled())
> dev_kfree_skb_irq(skb);
> else
> dev_kfree_skb(skb);
> }
>
>
> And the first thing dev_kfree_skb_irq() does is to dereference skb...

Yet dev_kfree_skb() --> kfree_skb() starts with the standard idiom

if (unlikely(!skb))
return
Seems to me that the finger of blame is more appropriately pointed
at either dev_kfree_skb_any() or dev_kfree_skb_irq() ...

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-12 08:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site