Messages in this thread | | | Subject | Re: [patch 08/19] i386: cleanup apic code | From | Arjan van de Ven <> | Date | Fri, 10 Nov 2006 11:04:59 +0100 |
| |
> > /* > * Knob to control our willingness to enable the local APIC. > + * > + * -1=force-disable, +1=force-enable
mind doing 2 defines for these? Makes things more readable I suspect
> - return maxlvt; > + return APIC_INTEGRATED(GET_APIC_VERSION(v)) ? GET_APIC_MAXLVT(v) : 2; > }
why not use lapic_is_integrated() here? > \ > + if (cpu_has_tsc) > + apic_printk(APIC_VERBOSE, "..... CPU clock speed is "
please put "approximated at" or something here; or people will call supportlines if they bought a 3.4Ghz processor and this shows 3.39999Ghz
> +EXPORT_SYMBOL(switch_APIC_timer_to_ipi);
why is this exported at all? Modules really shouldn't be touching apic level details....
this patch is extremely difficult to review because diff has made a mess out of it ;(
-- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |