lkml.org 
[lkml]   [2006]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH -mm 3/3][AIO] - AIO completion signal notification
    From
    Date
    On Thu, 2006-11-09 at 11:18 -0800, Badari Pulavarty wrote:
    > On Thu, 2006-11-09 at 16:59 +0100, Sébastien Dugué wrote:
    >
    > > @@ -1549,8 +1657,7 @@ int fastcall io_submit_one(struct kioctx
    > > ssize_t ret;
    > >
    > > /* enforce forwards compatibility on users */
    > > - if (unlikely(iocb->aio_reserved1 || iocb->aio_reserved2 ||
    > > - iocb->aio_reserved3)) {
    > > + if (unlikely(iocb->aio_reserved1)) {
    > > pr_debug("EINVAL: io_submit: reserve field set\n");
    > > return -EINVAL;
    >
    > Is there a reason for not checking "aio_reserved3" ?
    > You are still not using it. Right ?
    >

    Yep, forgot this one.

    Thanks,

    Sébastien.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-10 10:25    [W:0.035 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site