[lkml]   [2006]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 40/61] SCTP: Always linearise packet on input
-stable review patch.  If anyone has any objections, please let us know.
From: Herbert Xu <>

I was looking at a RHEL5 bug report involving Xen and SCTP
It turns out that SCTP wasn't written to handle skb fragments at
all. The absence of any calls to skb_may_pull is testament to

It just so happens that Xen creates fragmented packets more often
than other scenarios (header & data split when going from domU to
dom0). That's what caused this bug to show up.

Until someone has the time sits down and audits the entire net/sctp
directory, here is a conservative and safe solution that simply
linearises all packets on input.

Signed-off-by: Herbert Xu <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Chris Wright <>

net/sctp/input.c | 3 +++
1 file changed, 3 insertions(+)
--- linux-
+++ linux-
@@ -135,6 +135,9 @@ int sctp_rcv(struct sk_buff *skb)


+ if (skb_linearize(skb))
+ goto discard_it;
sh = (struct sctphdr *) skb->h.raw;

/* Pull up the IP and SCTP headers. */
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-11-01 06:55    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean