Messages in this thread | | | Date | Wed, 1 Nov 2006 20:52:08 +0100 | From | Wim Van Sebroeck <> | Subject | Re: [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104 unit |
| |
Hi Gabriele,
> A simple watchdog driver for Digital-Logic's MSM-P5XEN PC104 unit. > The watchdog is a LTC1232 controlled by a single I/O port @ 0x1037. > The watchdog must be refreshed (writing a single byte) to the device > at least every 600 msecs (which is a little of overhead, but PC104 > industrial applications requires a high degree of safety/reliability.)
I was looking at your code and have a question: > +static void > +wdt_ping(void) > +{ > + /* > + * Clear-pulse trailing edge scheduling. > + * > + * We use mod_timer() rather than add_timer() because a timer could > + * be already activated. > + * kernel/timer.c: > + * "... since add_timer() cannot modify an already running timer." > + */ > + mod_timer(&wdt_timer, jiffies + (HZ / 10)); > + > + wdt_disable(); > +}
Shouldn't this be wdt_enable();? Please clarify.
Thanks, Wim.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |