Messages in this thread | | | Date | Wed, 1 Nov 2006 11:36:28 -0500 | From | "Ed L. Cashin" <> | Subject | Re: [2.6.19 patch] drivers/block/aoe/aoedev.c: fix NULL dereference |
| |
On Wed, Nov 01, 2006 at 01:40:25AM +0100, Adrian Bunk wrote: > This patch fixes a NULL dereference introduced by > commit e407a7f6cd143b3ab4eb3d7e1cf882e96b710eb5: > > This quite unusual error handling through a switch introduces NULL > dereferences if exactly one of the two k{c,z}alloc's failed.
Hmm. If exactly one of the two fails, then the value of the switch conditional is 1 (well, certainly not zero). It will jump over the zero case, and there's a return in the default case, so I'm having trouble seeing the danger.
What exactly is Coverity saying? That would be interesting to know.
-- Ed L Cashin <ecashin@coraid.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |