lkml.org 
[lkml]   [2006]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 27/61] ALSA: Fix re-use of va_list
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    [PATCH] ALSA: Fix re-use of va_list

    The va_list is designed to be used only once. The current code
    may pass va_list arguments multiple times and may cause Oops.
    Copy/release the arguments temporarily to avoid this problem.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>

    ---
    sound/core/info.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- linux-2.6.18.1.orig/sound/core/info.c
    +++ linux-2.6.18.1/sound/core/info.c
    @@ -119,7 +119,10 @@ int snd_iprintf(struct snd_info_buffer *
    len = buffer->len - buffer->size;
    va_start(args, fmt);
    for (;;) {
    - res = vsnprintf(buffer->buffer + buffer->curr, len, fmt, args);
    + va_list ap;
    + va_copy(ap, args);
    + res = vsnprintf(buffer->buffer + buffer->curr, len, fmt, ap);
    + va_end(ap);
    if (res < len)
    break;
    err = resize_info_buffer(buffer, buffer->len + PAGE_SIZE);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-01 06:45    [W:0.021 / U:94.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site