Messages in this thread | | | Date | Wed, 01 Nov 2006 00:07:51 -0500 | From | Jeff Garzik <> | Subject | Re: AHCI should try to claim all AHCI controllers |
| |
Conke Hu wrote: > Hi all, > According to PCI 3.0 spec, ACHI's PCI class code is 0x010601, > and I suggest the ahci driver had better try to claim all ahci > controllers, pls see the following patch: > > diff -Nur linux-2.6.17/drivers/scsi/ahci.c > linux-2.6.17-ahci/drivers/scsi/ahci.c > --- linux-2.6.17/drivers/scsi/ahci.c 2006-06-18 09:49:35.000000000 > +0800 > +++ linux-2.6.17-ahci/drivers/scsi/ahci.c 2006-10-31 > 22:50:54.000000000 +0800 > @@ -296,6 +296,11 @@ > board_ahci }, /* ATI SB600 non-raid */ > { PCI_VENDOR_ID_ATI, 0x4381, PCI_ANY_ID, PCI_ANY_ID, 0, 0, > board_ahci }, /* ATI SB600 raid */ > + /* Claim all AHCI controllers not listed above. > + * According to PCI 3.0, AHCI's class code is 0x010601 > + */ > + { PCI_AND_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, 0x010601, > 0xffffff, > + board_ahci }, > { } /* terminate list */ > };
Since things have settled in this area, yes, this would probably be a good thing to add.
For the benefit of others, some background: we should not be -removing- any PCI IDs due to this, because quite often the PCI class code will be RAID or something else, yet still be drive-able with this ahci driver.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |