lkml.org 
[lkml]   [2006]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable.
Al Viro a écrit :
> On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
>
>> And " (deleted)" is correctly added to deleted files.
>
> The hell it will.
>
> touch a
> touch b
> exec 5<a
> mv b a
> ls -l /proc/$$/fd/5
>
> With your patch and without it, please.

Yes I will do, thanks.

>
> PS: getting rid of socket dentries is a bad idea with the capital "Fuck, No".
> For those who want to see where does that path lead and are attracted to
> trainwrecks in general I can recommend *BSD socket handling. They have
> paid quite painfully for lack of proper vnodes. It's simply not worth
> the resulting trouble.

I have one server with one million sockets, wasting 210 MB of ram for dentries
that are only used when some guy does some /proc/$pid/fd work

Socket hot path already dont use anymore dentries, thanks to file->private_data

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-01 10:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site