lkml.org 
[lkml]   [2006]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
On Mon, Oct 09, 2006 at 09:14:46PM +1000, Herbert Xu wrote:

> Actually, crypto_alloc_tfm is an obsolete function which is supposed
> to maintain its previous semantics of returning NULL or success.

I misunderstood about crypto_alloc_tfm().

BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm().
Should we mark it as __deprecated?

> I don't quite see where the problem with crypto_alloc_base is.

- __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure.
But it returns NULL.

- crypto_alloc_base() may not return -EINTR on signal_pending()

I'll fix the patch and resend with more clear description later.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-09 13:57    [W:0.085 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site