lkml.org 
[lkml]   [2006]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    From
    On Mon, Oct 09, 2006 at 05:58:12PM +0900, Akinobu Mita wrote:
    > crypto_alloc_tfm() and crypto_alloc_base() are suppose to return error code
    > as pointer on failures. But there are some cases where they return NULL
    > (for example, crypto_alloc_tfm() returns NULL on kzalloc() failure)
    >
    > This patch fixes that wrong return value, and also fixes tcrypt so that it can
    > detect error code correctly.

    Actually, crypto_alloc_tfm is an obsolete function which is supposed
    to maintain its previous semantics of returning NULL or success.

    I don't quite see where the problem with crypto_alloc_base is.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-09 13:17    [W:0.019 / U:108.992 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site