Messages in this thread | | | Date | Tue, 10 Oct 2006 13:53:39 +1000 | Subject | Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value | From | Herbert Xu <> |
| |
On Mon, Oct 09, 2006 at 08:55:26PM +0900, Akinobu Mita wrote: > > I misunderstood about crypto_alloc_tfm(). > > BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm(). > Should we mark it as __deprecated?
Probably. Although anybody using crypto_alloc_tfm will probably also use the old crypto interface which gives plenty of warnings already.
> - __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure. > But it returns NULL. > > - crypto_alloc_base() may not return -EINTR on signal_pending() > > I'll fix the patch and resend with more clear description later.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |