Messages in this thread | | | Date | Mon, 9 Oct 2006 19:22:01 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH 2.6.19-git] Fix error handling in create_files() |
| |
On Mon, 9 Oct 2006 19:03:57 +0200, Luca Tettamanti <kronos.it@gmail.com> wrote:
> While we are at it: is it safe to always call sysfs_remove_group even if > the preceding sysfs_create_group failed?
No, it will oops in remove_dir(). (See also the recent discussion in "drivers/base: error handling fixes" - drivers/base/topology.c has problems in that area as well...)
-- Cornelia Huck Linux for zSeries Developer Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |