Messages in this thread | | | Date | Mon, 9 Oct 2006 09:48:20 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2.6.19-git] Fix error handling in create_files() |
| |
On Mon, Oct 09, 2006 at 06:40:17PM +0200, Luca Tettamanti wrote: > Hello, > current code in create_files() detects an error iff the last > sysfs_add_file fails: > > for (attr = grp->attrs; *attr && !error; attr++) { > error = sysfs_add_file(dir, *attr, SYSFS_KOBJ_ATTR); > } > if (error) > remove_files(dir,grp); > > In order to do the proper cleanup upon failure 'error' must be checked on > every iteration.
But it is, look up there in the "!error" test, right?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |