Messages in this thread | | | Subject | Re: [PATCH 01/10] -mm: clocksource: increase initcall priority | From | OGAWA Hirofumi <> | Date | Sun, 08 Oct 2006 03:41:36 +0900 |
| |
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Daniel Walker <dwalker@mvista.com> writes: > >> On Sun, 2006-10-08 at 00:40 +0900, OGAWA Hirofumi wrote: >>> Daniel Walker <dwalker@mvista.com> writes: >>> >>> > Index: linux-2.6.17/drivers/clocksource/acpi_pm.c >>> > =================================================================== >>> > --- linux-2.6.17.orig/drivers/clocksource/acpi_pm.c >>> > +++ linux-2.6.17/drivers/clocksource/acpi_pm.c >>> > @@ -174,4 +174,4 @@ pm_good: >>> > return clocksource_register(&clocksource_acpi_pm); >>> > } >>> > >>> > -module_init(init_acpi_pm_clocksource); >>> > +postcore_initcall(init_acpi_pm_clocksource); >>> >>> Current code is assumeing DECLARE_PCI_FIXUP_EARLY() is called before >>> init_acpi_pm_clocksource(). >>> >>> We'll need to change it. >> >> We can add a call to clocksource_rating_change() inside >> acpi_pm_need_workaround(), are there deeper dependencies? > > There is no deeper dependencies. If it's meaning > clocksource_reselect() in current git, it sounds good to me.
Ah, I was forgetting why I didn't before. If it's a buggy pmtmr, we'll get corrupted time until re-selecting the clocksource.
If anybody doesn't care this will be good with it. If not, we would need to back to old one. IIRC, John did it. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |