lkml.org 
[lkml]   [2006]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
    From
    Date
    Ar Gwe, 2006-10-06 am 10:27 +0530, ysgrifennodd Amol Lad:
    > Signed-off-by: Amol Lad <amol@verismonetworks.com>
    > ---
    > rio_linux.c | 3 +++
    > 1 files changed, 3 insertions(+)
    > ---
    > diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/char/rio/rio_linux.c linux-2.6.19-rc1/drivers/char/rio/rio_linux.c
    > --- linux-2.6.19-rc1-orig/drivers/char/rio/rio_linux.c 2006-10-05 14:00:43.000000000 +0530
    > +++ linux-2.6.19-rc1/drivers/char/rio/rio_linux.c 2006-10-05 14:50:00.000000000 +0530
    > @@ -1181,6 +1181,9 @@ static void __exit rio_exit(void)
    > }
    > /* It is safe/allowed to del_timer a non-active timer */
    > del_timer(&hp->timer);
    > +
    > + if (hp->Caddr)
    > + iounmap(hp->Caddr);
    > }

    I don't think this is sufficient because it may be unmapped earlier on
    error but hp->Caddr is not then cleared .

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-06 12:59    [W:0.022 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site