lkml.org 
[lkml]   [2006]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] VM: Fix the gfp_mask in invalidate_complete_page2
    On Fri, 06 Oct 2006 19:09:29 -0400
    Steve Dickson <SteveD@redhat.com> wrote:

    > > Well, it wasn't attached, but I can simulate it.
    > >
    > > invalidate_complete_page() wants to be called from inside spinlocks by
    > > drop_pagecache(), so if we wanted to pull the same trick there we'd need to
    > > pass a new flag into invalidate_inode_pages().
    > That seems abit broken (wrt performance) that drop_pagecache_sb() holds
    > the fairly popular inode_lock while it invalidate pages...
    > Nobody else seem to...

    Yes, it was very rude of me. But it's just a debugging thing, and is
    privileged.

    I removed a cond_resched() from in there in the process. If we make the
    invalidate_inode_pages() caller pass in a must_be_atomic flag then the
    cond_resched() can be resuscitated.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-07 01:23    [W:0.022 / U:29.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site