lkml.org 
[lkml]   [2006]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
On Fri, 06 Oct 2006 11:08:57 +0530
Amol Lad <amol@verismonetworks.com> wrote:

> msnd_pinnacle.c | 10 ++++++++++

This driver fails to check that ioremap() actually succeeded. Hence with
this patch we can end up doing iounmap(NULL).

Now it _could_ be that the kernel permits iounmap(NULL). But I don't
recall that being the rule, and from my reading the powerpc 64-bit iounmap
(at least) will go splat if we do this to it. Most other implementations
will permit iounmap(NULL) by accident.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-07 01:07    [from the cache]
©2003-2011 Jasper Spaans