lkml.org 
[lkml]   [2006]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateFri, 6 Oct 2006 22:52:59 +0200 (MEST)
FromJan Engelhardt <>
SubjectRe: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]

>> >+ * the massive ternary operator construction
>> >+ (sizeof(n) <= 4) ? \
>> >+ __ilog2_u32(n) : \
>> >+ __ilog2_u64(n) \
>>
>> Should not this be: sizeof(n) <= sizeof(u32)
>
>Were you planning on porting Linux to a machine with non-8-bit-bytes any
>time soon? Because there's a lot more to fix than this.

I am considering the case [assuming 8-bit-byte machines] where
sizeof(u32) is not 4. Though I suppose GCC will probably make a 32-bit
type up if the hardware does not know one.


-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-06 23:01    [from the cache]
©2003-2010