lkml.org 
[lkml]   [2006]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
Vivek Goyal wrote:
>>
> Hi Eric,
>
> I have added cld in the regenerated patch below.
>

No, the cld needs to be earlier. It turns out this isn't the first use
of string instructions.

I think I am going to add DF=0 as a documented entry condition; it
definitely seems all current Linux kernels require it.

> Also one more minor nit. stosb relies on being %es set properly. By the
> time control reaches loader_ok, i could not find %es being set explicitly
> hence I am assuming we are relying on bootloader to set it up for us.
>
> Maybe we can be little more paranoid and setup the %es before stosb. I
> have done this change too in the attached patch. Pleaese have a look.
> I know little about assembly code.

%es being set is part of the requirements list, although it *would* be
better to not rely on any segment registers being set at all (only rely
on %cs.)

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-06 20:57    [from the cache]
©2003-2011 Jasper Spaans