Messages in this thread | | | Date | Wed, 4 Oct 2006 18:10:03 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer |
| |
On Wed, 4 Oct 2006 17:56:30 -0700 Reinette Chatre <reinette.chatre@linux.intel.com> wrote:
> + if (is_user) { > + if (__get_user(c, buf++)) > + return -EFAULT; > + } > + else > + c = *buf++;
Is this actually needed? __get_user(kernel_address) works OK and (believe it or not, given all the stuff it involves) boils down to a single instruction. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |