Messages in this thread | | | Date | Wed, 04 Oct 2006 09:10:00 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] fs/partitions/check: add sysfs error handling |
| |
Al Viro wrote: > On Wed, Oct 04, 2006 at 08:19:00AM -0400, Jeff Garzik wrote: >> Handle errors thrown in disk_sysfs_symlinks(), and propagate back >> to caller. >> >> The callers and associated functions don't do a real good job >> of handling kobject errors anyway (add_partition, register_disk, >> rescan_partitions), so this should do until something better comes >> along. > > I'm not sure that failure to create these symlinks should be fatal, > to be honest...
Fair enough, though FWIW the failure is almost always -EFAULT or -ENOMEM, i.e. -ESYSTEMINTROUBLE...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |