Messages in this thread | | | From | Andi Kleen <> | Subject | Re: BUG-lockdep and freeze (was: Arrr! Linux 2.6.18) | Date | Wed, 4 Oct 2006 14:03:37 +0200 |
| |
On Wednesday 04 October 2006 13:58, Jan Beulich wrote: > >> >Proposed patch appended. Jan, what do you think? > >> > >> As said above - I thought we added zero-termination already. > > > >For head.S but not for kernel_thread I think. At least I can't > >find any existing code for kernel_thread(). > > 2.6.18-git11 (i386) already has an annotated version of > kernel_thread_helper() in entry.S, including the pushing of a > fake (zero) return address. x86-64 has child_rip with the > added push even in original 2.6.18.
True.
I wonder why it didn't work then and why my patch fixed the crash.
Ok the pushl is outside the CFI_STARTPROC
ENTRY(kernel_thread_helper) pushl $0 # fake return address for unwinder CFI_STARTPROC ..
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |