lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Re: Battery class driver.
    On Sat, Oct 28, 2006 at 08:12:41PM +0200, Shem Multinymous wrote:
    > Hi David,
    >
    > On 10/28/06, David Zeuthen <davidz@redhat.com> wrote:
    > >What about just prepending the unit to the 'threshold' file? Then user
    > >space can expect the contents of said file to be of the form "%d %s". I
    > >don't think that violates the "only one value per file" sysfs mantra.
    >
    > The tp_smapi battery driver did just this ("16495 mW"). But I dropped
    > it in a recent version when Pavel pointed out the rest of sysfs, hwmon
    > included, uses undecorated integers.
    > Consistency aside, it seems reasonable and convenient. You have to
    > decree that writes to the attributes (where relevant) don't include
    > the units, of course, so no one will expect the kernel to parse that.
    >
    > There's an issue here if a drunk driver decides to specify (say)
    > capacity_remaining in mWh and capacity_last_full in mAa, which will
    > confuse anyone comparing those attributest. So don't do that.
    >
    > Jean, what's your opinion on letting hwmon-ish attributes specify
    > units as "%d %s" where these are hardware-dependent?

    No, the sysfs files should just always keep the same units as
    documented. It's easier all around that way.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-31 08:59    [W:0.022 / U:2.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site