lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix potential NULL pointer dereference in echoaudio midi.
On Tue, 31 Oct 2006, Jesper Juhl wrote:

> In sound/pci/echoaudio/midi.c::snd_echo_midi_output_write(), there's a risk
> of dereferencing a NULL 'chip->midi_out'.
> This patch contains the obvious fix as also used a bit higher up in the
> same function.
>

How about just adding an early test:
if (!chip->midi_out)
goto out;

and adding a label for out before the chip->lock unlock? We still need to
clear chip->midi_full so we still require the spinlock, but there's no
reason we should be testing chip->midi_out multiple times since the
remaining code path in its entirety depends on it.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-31 23:15    [W:0.069 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site