Messages in this thread |  | | | Date | Tue, 31 Oct 2006 17:40:21 +0100 | | From | "Jesper Juhl" <> | | Subject | Re: [PATCH] NFS: nfsaclsvc_encode_getaclres() - Fix potential NULL deref and tiny optimization. |
| |
On 31/10/06, Andreas Gruenbacher <agruen@suse.de> wrote: > On Saturday 28 October 2006 00:01, Jesper Juhl wrote: > > > > 3) There are two locations in the function where we may return before > > > > we use the value of the variable 'w', but we compute it at the very top > > > > of the function. So in the case where we return early we have wasted a > > > > few cycles computing a value that was never used. > > Computing w later in the function is fine. > > > > w should be an unsigned int. > > > > Makes sense. > > No, this breaks the while loop further below: with an unsigned int, the loop > counter underflows and wraps. > Whoops. OK.
> Please fix this identically in fs/nfsd/nfs2acl.c and fs/nfsd/nfs3acl.c. > Sure thing, expect patches later this evening.
BTW: I posted an add-on patch on top of my first one - apart from the "make w unsigned" bit, is the rest of that OK?
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |