Messages in this thread | | | Date | Mon, 30 Oct 2006 20:00:53 -0800 | From | Paul Jackson <> | Subject | Re: [PATCH] Allow a larger buffer for writes to cpuset files |
| |
Paul M wrote: > @@ -1292,7 +1292,7 @@ static ssize_t cpuset_common_file_write( > int retval = 0; > > /* Crude upper limit on largest legitimate cpulist user might write. */ > - if (nbytes > 100 + 6 * NR_CPUS) > + if (nbytes >= PAGE_SIZE)
On a system with 4 Kbyte pages, this imposes a tighter limit if NR_CPUS is > 666.
On a system with 16 Kbyte pages, this imposes a tighter limit if NR_CPUS is > 2714.
Those CPU counts don't look that futuristic to me.
And it makes the limit more aribitrary ... like what the heck does that check have to do with PAGE_SIZE ?
How about coding for the possibility that either NR_CPUS or MAX_NUMNODES is larger, and removing 'cpu' from the comment:
/* Crude upper limit on largest legitimate list user might write. */ if (nbytes > 100 + 6 * max(NR_CPUS, MAX_NUMNODES))
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |