lkml.org 
[lkml]   [2006]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] drivers cris: return on NULL dev_alloc_skb()
    If the next descriptor array entry cannot be allocated by dev_alloc_skb(),
    return immediately so it is not dereferenced later. We cannot register
    the device with a partial descriptor list.

    Cc: Mikael Starvik <starvik@axis.com>
    Signed-off-by: David Rientjes <rientjes@cs.washington.edu>
    ---
    drivers/net/cris/eth_v10.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c
    index 966b563..a03d781 100644
    --- a/drivers/net/cris/eth_v10.c
    +++ b/drivers/net/cris/eth_v10.c
    @@ -509,6 +509,8 @@ etrax_ethernet_init(void)
    * does not share cacheline with any other data (to avoid cache bug)
    */
    RxDescList[i].skb = dev_alloc_skb(MAX_MEDIA_DATA_SIZE + 2 * L1_CACHE_BYTES);
    + if (!RxDescList[i].skb)
    + return -ENOMEM;
    RxDescList[i].descr.ctrl = 0;
    RxDescList[i].descr.sw_len = MAX_MEDIA_DATA_SIZE;
    RxDescList[i].descr.next = virt_to_phys(&RxDescList[i + 1]);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-10-31 02:03    [W:0.027 / U:0.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site